Re: pgsql: Remove unneeded defines from pg_config.h.in

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in
Date: 2026-01-05 00:41:23
Message-ID: 1193764.1767573683@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Remove unneeded defines from pg_config.h.in
> This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
> pg_config.h.in, cleanup that could have been done in 25f36066dd2a.

This patch is not okay. pg_config.h.in is a generated file and
hand modifications in it will not do.

If we don't need these symbols anymore, the right fix is to remove
the probes for these headers in the autoconf and meson scripts.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-01-05 00:49:26 Re: pgsql: Remove unneeded defines from pg_config.h.in
Previous Message Michael Paquier 2026-01-05 00:30:35 pgsql: Remove unneeded defines from pg_config.h.in