| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Drop type "smgr"? |
| Date: | 2019-02-28 17:39:04 |
| Message-ID: | 11912.1551375544@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Feb 28, 2019 at 1:03 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> Nothing seems to break if you remove it (except for some tests using
>> it in an incidental way). See attached.
> FWIW, +1 from me.
To be clear, I'm not objecting to the proposed patch either. I was
just wondering where we plan to go from here, given that smgr.c wasn't
getting removed.
BTW, there is stuff in src/backend/storage/smgr/README that is
already obsoleted by this patch, and more that might be obsoleted
if development proceeds as discussed here. So that needs a look.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-02-28 17:45:23 | plpgsql variable named as SQL keyword |
| Previous Message | Robert Haas | 2019-02-28 17:36:50 | Re: Drop type "smgr"? |