Re: Speed up ICU case conversion by using ucasemap_utf8To*()

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Jeff Davis <pgsql(at)j-davis(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, zengman <zengman(at)halodbtech(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speed up ICU case conversion by using ucasemap_utf8To*()
Date: 2026-04-14 00:20:25
Message-ID: 118ca69e-47eb-42e1-83e9-72ccf40dd6fd@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/13/26 20:40, Jeff Davis wrote:
> Thank you both!

Thanks!

> Committed with minor revisions:
>
> * also check the status code, just to be sure

If we do that shouldn't we also do the same in the other callsites in
initdb.c uloc_getLanguage()? Maybe something like the attached. Also I
wonder if maybe other ICU functions have the same risk.

Andreas

Attachment Content-Type Size
v1-0001-Always-check-for-untermianted-strings-when-callin.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2026-04-14 00:28:41 Re: Speed up ICU case conversion by using ucasemap_utf8To*()
Previous Message Peter Smith 2026-04-14 00:03:47 Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+