Re: Make frontend programs relink after libpgfeutils changes

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Yingying Chen <cyy9255(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Make frontend programs relink after libpgfeutils changes
Date: 2026-06-16 22:47:42
Message-ID: 118D5697-D880-4845-A040-5DA86CF2FAF2@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jun 16, 2026, at 20:44, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Jun-16, Yingying Chen wrote:
>
>> I tried the patch, and it works properly. But I see meson automatically
>> rebuilds some more tools than src/bin/ tools, such as
>> contrib/oid2name/oid2name, src/tools/pg_bsd_indent/pg_bsd_indent, etc., do
>> you plan to handle them also?
>
> Hmm, isn't that bogus? oid2name at least doesn't depend on fe_utils as
> far as I can see. Maybe meson is overeagerly inheriting that dependency
> from somewhere else. If that's the case then we don't want Make to do
> the same (though I don't dare suggest to clean up Meson not to.)
>
> --
> Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

Thanks for your comments. Actually, I checked that while working on v1.

There are 15 non-src/bin tools that get rebuilt by meson:

* contrib/oid2name/oid2name
* contrib/vacuumlo/vacuumlo
* src/interfaces/ecpg/preproc/ecpg
* src/interfaces/ecpg/test/pg_regress_ecpg
* src/test/isolation/isolationtester
* src/test/isolation/pg_isolation_regress
* src/test/modules/libpq_pipeline/libpq_pipeline
* src/test/modules/oauth_validator/oauth_hook_client
* src/test/modules/test_escape/test_escape
* src/test/modules/test_int128/test_int128
* src/test/modules/test_json_parser/test_json_parser_incremental
* src/test/modules/test_json_parser/test_json_parser_perf
* src/test/regress/pg_regress
* src/timezone/zic
* src/tools/pg_bsd_indent/pg_bsd_indent

Only src/test/modules/test_escape/test_escape really depends on libpgfeutils.a, and I included it in v1. I think Meson may involve some broader dependency logic that causes the others to be relinked, but I don’t want to touch that part in this patch.

PFA v2, only rebased, and with the reviewer and discussion added to the commit message.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v2-0001-Make-frontend-programs-relink-after-libpgfeutils-.patch application/octet-stream 15.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2026-06-16 22:50:20 Re: use of SPI by postgresImportForeignStatistics
Previous Message Enrique Sánchez 2026-06-16 22:32:40 Re: Extended statistics improvement: multi-column MCV missing values