MemoryContextStats tweak: show tree structure

From: Neil Conway <neilc(at)samurai(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: MemoryContextStats tweak: show tree structure
Date: 2007-08-07 00:48:28
Message-ID: 1186447708.16321.70.camel@dell.linuxdev.us.dell.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Previously, MemoryContextStats() simply emitted a line of output for
each MemoryContext. This is fine, but it makes it difficult to see the
shape of the MemoryContext hierarchy. Attached is a trivial patch to
indent each context by "4 * level" spaces, where "level" is the depth of
the node within the subtree printed by MemoryContextStats().

For example, suppose we have three contexts beneath TopMemoryContext:

TopMemoryContext (...)
FooContext (...)
BarContext (...)
BazContext (...)

With the patch, these might be printed as:

TopMemoryContext (...)
FooContext (...)
BarContext (...)
BazContext (...)

Assuming that's the parent/child relationship between them, of course.

Obviously this is just for debugging, but I've found it useful while
looking at some memory-related issues. Any comments or objections to
including this in HEAD?

-Neil

Attachment Content-Type Size
mcxt_stats_indent_pgdg-1.patch text/x-patch 4.9 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-08-07 00:56:03 Re: MemoryContextStats tweak: show tree structure
Previous Message Tom Lane 2007-08-07 00:18:38 Re: Memory leak in nodeAgg