| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, bt22nakamorit <bt22nakamorit(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix error message for MERGE foreign tables |
| Date: | 2022-10-14 14:43:34 |
| Message-ID: | 1184053.1665758614@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> Or maybe we can make it even earlier, when we expand an RTE for a
> partitioned table and add result tables to leaf_result_relids.
I'm not really on board with injecting command-type-specific logic into
completely unrelated places just so that we can throw an error a bit
earlier. Alvaro's suggestion of make_modifytable seemed plausible,
not least because it avoids spending any effort when the command
couldn't be MERGE at all.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Karina Litskevich | 2022-10-14 15:16:56 | Re: Error for WITH options on partitioned tables |
| Previous Message | Dagfinn Ilmari Mannsåker | 2022-10-14 14:31:26 | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |