| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: warnings for invalid function casts |
| Date: | 2020-07-04 14:16:07 |
| Message-ID: | 1183184.1593872167@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Do people prefer a typedef or just writing it out, like it's done in the
> Python code?
I'm for a typedef. There is *nothing* readable about "(void (*) (void))",
and the fact that it's theoretically incorrect for the purpose doesn't
exactly aid intelligibility either. With a typedef, not only are
the uses more readable but there's a place to put a comment explaining
that this is notionally wrong but it's what gcc specifies to use
to suppress thus-and-such warnings.
> But if we prefer a typedef then I'd propose
> GenericFuncPtr like in the initial patch.
That name is OK by me.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | movead.li@highgo.ca | 2020-07-04 14:56:17 | Re: POC and rebased patch for CSN based snapshots |
| Previous Message | Joe Conway | 2020-07-04 13:53:28 | Re: pg_read_file() with virtual files returns empty string |