Re: bug/oversight in TestLib.pm and PostgresNode.pm

On 2017-03-23 03:28, Michael Paquier wrote:
> On Thu, Mar 23, 2017 at 12:51 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>> While trying to test pgbench's stderr (looking for 'creating tables'
>> in
>> output of the initialisation step) I ran into these two bugs (or
>> perhaps
>> better 'oversights').
>
> + if (defined $expected_stderr) {
> + like($stderr, $expected_stderr, "$test_name: stderr matches");
> + }
> + else {
> is($stderr, '', "$test_name: no stderr");
> - like($stdout, $expected_stdout, "$test_name: matches");
> + }
> To simplify that you could as well set expected_output to be an empty
> string, and just use like() instead of is(), saving this if/else.

(I'll assume you meant '$expected_stderr' (not 'expected_output'))

That would be nice but with that, other tests start complaining:
"doesn't look like a regex to me"

To avoid that, I uglified your version back to:

+ like($stderr, (defined $expected_stderr ? $expected_stderr :
qr{}),
+ "$test_name: stderr matches");

I did it like that in the attached patch
(0001-testlib-like-stderr.diff).

The other (PostgresNode.pm.diff) is unchanged.

make check-world without error.

Thanks,

Erik Rijkers