| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: cleanup standard includes |
| Date: | 2002-09-24 21:36:14 |
| Message-ID: | 11783.1032903374@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Neil Conway writes:
>> This patch removes a bunch of superfluous #include directives: if
>> postgres.h or c.h includes a system header (such as stdio.h or
>> stdlib.h), there's no need to specifically include it in any of the .c
>> files in the backend.
> I think we should keep this for 7.4. I found out today that include file
> reorganization can have bizarre side effects that be had better not deal
> with now.
It looked pretty safe to me ... but I agree with Peter that this is a
bad time to be taking unnecessary risks. Code cleanup activities can be
held for 7.4.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-09-24 21:45:15 | Re: cleanup standard includes |
| Previous Message | Hannu Krosing | 2002-09-24 21:20:21 | Re: DROP COLUMN misbehaviour with multiple inheritance |