Re: pltcl valgrind output

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pltcl valgrind output
Date: 2017-12-20 15:32:30
Message-ID: 11744.1513783950@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> The following appears to keep valgrind quiet. AFAICT the problem isn't
> in our code.

I'm a little worried about whether this could suppress reports that
we do need to hear about. I don't know what TclNRRunCallbacks is
or does exactly, but just going by the name, it seems like it could
invoke non-Tcl code (ie, callbacks supplied by us). It'd be better
to constrain the call stack more tightly, particularly what the top
function is.

I agree that the traces you showed before don't look like our fault.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-12-20 15:37:12 Re: [HACKERS] replace GrantObjectType with ObjectType
Previous Message Tom Lane 2017-12-20 15:29:14 Re: AS OF queries