| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ucs_wcwidth vintage |
| Date: | 2017-11-03 19:38:54 |
| Message-ID: | 11718.1509737934@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Thomas Munro wrote:
>> src/backend/utils/mb/wchar.c contains a ~16 year old wcwidth
>> implementation that originally arrived in commit df4cba68, but the
>> upstream code[1] apparently continued evolving and there have been
>> more Unicode revisions since.
> I think we should update it to current upstream source, then, just like
> we (are supposed to) do for any other piece of code we adopt.
+1 ... also, is that upstream still the best reference?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-11-03 19:52:04 | Re: [HACKERS] pgsql: Fix freezing of a dead HOT-updated tuple |
| Previous Message | Peter Geoghegan | 2017-11-03 19:36:59 | Re: [HACKERS] pgsql: Fix freezing of a dead HOT-updated tuple |