Re: missing rename support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Ali Dar <ali(dot)munir(dot)dar(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: missing rename support
Date: 2013-01-18 18:54:58
Message-ID: 11703.1358535298@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Ali Dar (ali(dot)munir(dot)dar(at)gmail(dot)com) wrote:
>> Find attached an initial patch for ALTER RENAME RULE feature. Please
>> note that it does not have any documentation yet.

> Just took a quick look through this. Seems to be alright, but why do we
> allow renaming ON SELECT rules at all, given that they must be named
> _RETURN? My thinking would be to check for that case and error out if
> someone tries it.

Agreed, we should exclude ON SELECT rules.

> You should try to keep variables lined up:

pgindent is probably a better answer than trying to get this right
manually.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-01-18 18:59:17 Re: Event Triggers: adding information
Previous Message Tom Lane 2013-01-18 18:46:18 Re: in-catalog Extension Scripts and Control parameters (templates?)