Re: mkid reference

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: mkid reference
Date: 2021-01-22 18:07:36
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 22 Jan 2021, at 12:56, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> And maybe even more interestnig -- is there a point to this whole
>> make_diff directory at all in these days of git? Or should we just
>> remove it rather than try to fix it?

> There's also src/tools/make_mkid which use this mkid tool. +1 for removing.
> If anything, it seems better replaced by extended documentation on the existing
> wiki article [0] on how to use "git format-patch".

I found man pages for mkid online --- it's apparently a ctags-like
code indexing tool, not something for patches. So maybe Bruce still
uses it, or maybe not. But as long as we've also got make_ctags and
make_etags in there, I don't have a problem with leaving make_mkid.

make_diff, on the other hand, certainly looks like technology whose
time has passed. I wonder about pgtest, too.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-01-22 18:38:17 Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
Previous Message Tom Lane 2021-01-22 17:32:16 Re: macOS SIP, next try