Re: [BUGS] There is a case in which psqlodbc-09.03.0400 returns unterminated strings on Windows.

From: Naoya Anzai <nao-anzai(at)xc(dot)jp(dot)nec(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-odbc(at)postgresql(dot)org" <pgsql-odbc(at)postgresql(dot)org>
Cc: Akio Iwaasa <aki-iwaasa(at)vt(dot)jp(dot)nec(dot)com>
Subject: Re: [BUGS] There is a case in which psqlodbc-09.03.0400 returns unterminated strings on Windows.
Date: 2015-09-24 01:02:53
Message-ID: 116262CF971C844FB6E793F8809B51C6EF6319@BPXM02GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

> Yep. This was already fixed in git master in January, in commit
> 532c0dad20087201feee3851652c114eb820311f.

Thank you!

I confirmed psql-odbc master is already fixed this bug.
While you are at it, could you fix a precision argument passed to stime2timestamp?

--- C:/work/psqlodbc-a2def3d/convert.c.orig Wed Sep 23 16:14:10 2015
+++ C:/work/psqlodbc-a2def3d/convert.c Thu Sep 24 09:01:50 2015
@@ -1247,8 +1247,7 @@
case PG_TYPE_TIMESTAMP:
/* sprintf(rgbValueBindRow, "%.4d-%.2d-%.2d %.2d:%.2d:%.2d",
std_time.y, std_time.m, std_time.d, std_time.hh, std_time.mm, std_time.ss); */
- len = stime2timestamp(&std_time, rgbValueBindRow, cbValueMax, FALSE,
- (int) (cbValueMax - len - 2) );
+ len = stime2timestamp(&std_time, rgbValueBindRow, cbValueMax, FALSE, 6 );
if (len + 1 > cbValueMax)
result = COPY_RESULT_TRUNCATED;
break;

In PostgreSQL, I think max number of digits of precision is always 6.

I hope to be able to use next release as soon as possible.

Regards,

Naoya
---
Naoya Anzai
Engineering Department
NEC Solution Inovetors, Ltd.
E-Mail: nao-anzai(at)xc(dot)jp(dot)nec(dot)com
---

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Jean-Marc Guazzo 2015-09-24 15:51:56 Re: Materialized Views
Previous Message Heikki Linnakangas 2015-09-22 12:45:06 Re: How to fix buffer overrun in Windows x32