Rationalizing declarations of src/common/ variables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Rationalizing declarations of src/common/ variables
Date: 2021-11-29 05:57:29
Message-ID: 1160385.1638165449@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

We've been burnt by this issue repeatedly (cf c2d1eea9e, d025cf88b,
11b500072) so I think it's time to try to formalize and document
what to do to export a variable from src/common/ or src/port/.

Here's a draft patch. I'm not in love with the name "PGDLLIMPORT_FE"
and would welcome better ideas.

regards, tom lane

Attachment Content-Type Size
improve-variable-export-declarations-1.patch text/x-diff 3.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2021-11-29 05:58:31 Re: Commitfest 2021-11 Patch Triage - Part 1
Previous Message Amit Kapila 2021-11-29 05:56:01 Re: Non-superuser subscription owners