| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - factor out echo code |
| Date: | 2021-07-02 21:33:39 |
| Message-ID: | 1158092.1625261619@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I think the most interesting case for decoration is the "step by step"
> mode, where you want the "title" that precedes each query be easily
> visible.
I'm okay with leaving the step-by-step prompt as-is, personally.
It's the inconsistency of the other ones that bugs me.
> Also: one place that prints queries that wasn't mentioned before is
> exec_command_print() in command.c.
Ah, I was wondering if anyplace outside common.c did so. But that
one seems to me to be a different animal -- it's not logging
queries-about-to-be-executed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2021-07-02 21:37:24 | Re: psql - factor out echo code |
| Previous Message | Ranier Vilela | 2021-07-02 21:22:56 | Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c) |