Re: [PATCH] fix compilation with gnu89

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Rosen Penev <rosenp(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] fix compilation with gnu89
Date: 2020-11-30 05:06:49
Message-ID: 1155714.1606712809@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2020-11-29 20:33:41 -0800, Rosen Penev wrote:
>> GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions.

> We require C99 support since postgres 12, and configure should end up
> choosing flags to make the compiler support that if possible.

Hmm, yeah, that's a good point ... why didn't configure select
"-std=gnu99" for you? This might boil down to trying to use
CFLAGS selected for one compiler with a different compiler.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-11-30 05:07:20 Re: Disable WAL logging to speed up data loading
Previous Message Krunal Bauskar 2020-11-30 05:02:04 Re: Improving spin-lock implementation on ARM.