Re: parse_expr.c:typecast_expression:return immediate on NULL input

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Hannes Eder <Hannes(at)HannesEder(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: parse_expr.c:typecast_expression:return immediate on NULL input
Date: 2007-11-23 17:12:37
Message-ID: 11540.1195837957@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hannes Eder <Hannes(at)HannesEder(dot)net> writes:
> in parse_expr.c:typecast_expression: return immediate on NULL input,
> i.e. do not lookup target type Oid as it is not required.

I think the existing ordering is intentional, to detect and error out
if the given typename is bogus.

It's fairly likely that the test for InvalidOid is dead code anyway,
but it's cheap enough that I'm not in a hurry to take it out.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2007-11-23 17:36:17 Re: Cleaner API for appendStringInfoVA
Previous Message Tom Lane 2007-11-23 17:03:56 Re: Cleaner API for appendStringInfoVA