Re: libpq OpenSSL and multithreading

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq OpenSSL and multithreading
Date: 2025-11-12 15:05:05
Message-ID: 1151F1C3-28CA-4E5E-A82B-37C55530E5C4@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 29 Oct 2025, at 10:41, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> On 22.10.25 10:59, Daniel Gustafsson wrote:

>>> On 1 Sep 2025, at 07:27, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>> I suggest that instead of adding the context to the Port structure, make a separate context struct for this purpose, for example:
>> Fair enough, done in the attached.
>
> This looks good to me. (I would not have the CallbackErr typedef, since that additional abstraction doesn't buy anything. But it's a small difference.)

Thanks, I removed the typedef and went ahead with this patch.

>> (sidenote; if our thread
>> local store code will use TLS then be-secure-openssl.c will be challenging to
>> read =)).
>
> Yes, let's rename it to SSL to avoid this. ;-)

Touché! =)

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-11-12 15:09:14 Re: alignas (C11)
Previous Message KAZAR Ayoub 2025-11-12 14:44:02 Re: Speed up COPY FROM text/CSV parsing using SIMD