Re: pg_ctl options checking

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_ctl options checking
Date: 2006-04-17 22:13:07
Message-ID: 1145311988.3273.69.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, 2006-04-17 at 15:12 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Bruce Momjian wrote:
> >> For a command as significant as pg_ctl, I can't see how making it
> >> _convenient_ is a good argument.
>
> > Well, loss of convenience is one argument in opposition to this change
> > but I don't see any argument in _favor_ of this change other than
> > "let's reject these option combinations", some of which seem perfectly
> > valid.
>
> Ignoring irrelevant arguments is a time-honored Unix tradition that
> contributes significantly to the usefulness of cc, for example.
> Would you be happy if cc rejected -D when being used only to link, say?
>
> I hadn't thought about this when Simon submitted the patch, but I'm
> with Peter: we should not reject arguments just because they're not
> relevant. If you can make a case that particular combinations strongly
> suggest user error, then let's reject those cases ... but not a blanket
> prohibition.

AFAICS -l -o on stop and -m on start could be ignored

Mixing options between register and non-registration commands definitely
indicates user error. So does mixing up -w and -W

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Brant 2006-04-17 23:53:56 [Win32] Problem with rename()
Previous Message Nicolas Barbier 2006-04-17 21:50:12 Re: Documentation patch: change a name in a grammar rule