Re: Remove nonmeaningful prefixes in PgStat_* fields

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields
Date: 2023-01-12 17:23:29
Message-ID: 1144412.1673544209@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I don't like this at all. With these prefixes in place, it's much more
> likely that you'll be able to grep the whole source tree and not run
> into tons of false positives. If you remove them, that tends to be not
> very workable. If we use these commits as precedent for expanding this
> sort of renaming across the tree, we'll soon end up with a very
> grep-unfriendly code base.

+1, that was my immediate fear as well.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-12 17:31:15 Re: on placeholder entries in view rule action query's range table
Previous Message Tom Lane 2023-01-12 17:20:50 Re: Refactor recordExtObjInitPriv()