| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "sulamul(at)gmail(dot)com" <sulamul(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: inefficient loop in StandbyReleaseLockList() |
| Date: | 2021-11-01 16:57:27 |
| Message-ID: | 1142780.1635785847@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Bossart, Nathan" <bossartn(at)amazon(dot)com> writes:
> On 10/31/21, 1:55 PM, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> 1. Attached is a proposed patch to get rid of the calls in trgm_regexp.c.
> Should there be a list_free(trgmNFA->queue) at the end of
> transformGraph()?
There could be, but that's visibly invoked only once per
createTrgmNFAInternal call, so I didn't think it was worthwhile
to do so (unlike the case for processState). If we were concerned
about leakage in that function, the hash table would be a far
bigger issue.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2021-11-01 17:02:49 | Re: inefficient loop in StandbyReleaseLockList() |
| Previous Message | Bossart, Nathan | 2021-11-01 16:50:55 | Re: inefficient loop in StandbyReleaseLockList() |