Re: Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Michael Paesold <mpaesold(at)gmx(dot)at>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, Marko Kreen <markokr(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)
Date: 2006-02-10 20:21:47
Message-ID: 1141.1139602907@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> The extra spaces is an interesting side-effect. In the past it would
> only have worked for the last column anyway, right?

Of course.

> Anyway, it is a fixable issue and I'd consider doing it if people think
> it's worth it.

I think it would be a good idea to expect this patch to cause zero
change in psql output except in the cases where there are actually
control characters in the data. Otherwise there are likely to be
complaints. (I'm already unhappy at the prospect that this means
every single regression test's output has changed, even if diff
--ignore-space is hiding them.)

I'd settle for stripping trailing blanks on the last line of a multiline
field value, if that'd be any easier than stripping them for all lines.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2006-02-10 21:03:18 Re: Scrollable cursors and Sort performance
Previous Message ohp 2006-02-10 20:09:39 Re: how is that possible

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2006-02-10 21:03:18 Re: Scrollable cursors and Sort performance
Previous Message Michael Paesold 2006-02-10 19:55:42 Re: Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)