Re: pgsql: Move btbulkdelete's vacuum_delay_point()

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Move btbulkdelete's vacuum_delay_point()
Date: 2006-02-14 20:46:40
Message-ID: 1139950000.1258.1017.camel@localhost.localdomain
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, 2006-02-14 at 13:20 -0400, Tom Lane wrote:
> Log Message:
> -----------
> Move btbulkdelete's vacuum_delay_point() call to a place in the loop where
> we are not holding a buffer content lock; where it was, InterruptHoldoffCount
> is positive and so we'd not respond to cancel signals as intended. Also
> add missing vacuum_delay_point() call in btvacuumcleanup. This should fix
> complaint from Evgeny Gridasov about failure to respond to SIGINT/SIGTERM
> in a timely fashion (bug #2257).

Cool and Interesting. That might explain some pretty dire performance
numbers from last week while running auto vacuum. Performance was
flat-lining for a while. Still need to investigate further though.

Best Regards, Simon Riggs

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-02-14 20:55:12 Re: pgsql: Move btbulkdelete's vacuum_delay_point()
Previous Message Simon Riggs 2006-02-14 17:58:21 Re: pgsql: Add psql option: -1 or --single-transaction