| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add psql option: -1 or |
| Date: | 2006-02-14 08:35:28 |
| Message-ID: | 1139906128.1258.814.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, 2006-02-13 at 16:02 -0500, Tom Lane wrote:
> Isn't this patch emitting the BEGIN at the wrong place?
>
> --
> -- PostgreSQL database dump
> --
>
> SET client_encoding = 'SQL_ASCII';
> SET check_function_bodies = false;
> SET client_min_messages = warning;
>
> BEGIN;
>
> --
> -- Name: SCHEMA public; Type: COMMENT; Schema: -; Owner: postgres
> --
>
> COMMENT ON SCHEMA public IS 'Standard public schema';
>
> That's not what I would call guaranteeing that all the commands execute
> successfully. What if the client encoding is unrecognized, for
> instance?
I'll move it then.
Best Regards, Simon Riggs
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2006-02-14 08:55:41 | Re: pgsql: Add psql option: -1 or --single-transaction |
| Previous Message | Simon Riggs | 2006-02-14 08:34:12 | Re: pgsql: Add psql option: -1 or --single-transaction |