From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Fix C4819 warning in MSVC |
Date: | 2021-11-01 16:12:40 |
Message-ID: | 1139878.1635783160@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 1 Nov 2021, at 14:56, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> +1, but there are also C4819 warnings in fe_utils/print.c. Can we get
>> rid of that too? That one's a bit more integral to the code, since
>> (I think) it's complaining about the comments in the unicode_style table.
>> But maybe we could replace those with Unicode codes + symbol names?
> Aha, I missed that one when skimming the (quite chatty) log. The attached
> addresses that file as well, replacing the comments with codepoints and names.
> It does make the section of the code more verbose, but also more readable IMO.
Generally +1, but I think you'll need to add some dashes to keep pgindent
from re-flowing those comment blocks (which would be a big hit to the
readability).
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2021-11-01 16:24:36 | Re: Improve logging when using Huge Pages |
Previous Message | Daniel Gustafsson | 2021-11-01 16:10:17 | Re: Fix C4819 warning in MSVC |