Re: [HACKERS] pgxs/windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pgxs/windows
Date: 2006-01-19 20:51:13
Message-ID: 1137703874.3073.6.camel@swithin
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Thu, 2006-01-19 at 15:33 -0500, Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > The difference between Magnus's and Andrew's is
> > that Magnus used MODULE_big (which means create a shared library), while
> > Andrew used MODULES. So, Magnus's only worked because he was creating a
> > DLL and that brought in the -L from MODULE_big.
>
> Ah, good catch.

As I understand the docs, one can use either to produce a dll. The
difference is how it processes the name.

>
> > I have applied the following patch to change /bin to /lib for Cygwin and
> > Win32.
>
> What about the question of whether $(DESTDIR) belongs there or not?
> I think we had concluded that PGXS shouldn't ever use $(DESTDIR),
> because that's only for install-time stuff.

Looks that way to me - IIRC it's only used by the regression suite.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-01-19 20:54:21 Re: [HACKERS] pgxs/windows
Previous Message Tom Lane 2006-01-19 20:46:28 Re: Bogus path in postmaster.opts

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-01-19 20:54:21 Re: [HACKERS] pgxs/windows
Previous Message Tom Lane 2006-01-19 20:48:03 Re: Uninstall scripts for contrib