| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: chained transactions |
| Date: | 2019-03-24 11:04:12 |
| Message-ID: | 1133e035-72d0-b9ef-dee1-6b2efd65ec38@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Patch has been committed, thanks.
On 2019-03-18 21:20, Fabien COELHO wrote:
> Minor remarks:
>
> In "xact.c", maybe I'd assign blockState in the else branch, instead of
> overriding it?
I think it was better the way it is, since logically the block state is
first set, then set again after the new transaction starts.
> About the static _SPI_{commit,rollback} functions: I'm fine with these
> functions, but I'm not sure about their name. Maybe
> _SPI_chainable_{commit,rollback} would be is clearer about their content?
I kept it as is, to mirror the names of the SQL commands.
> Doc looks clear to me. ISTM "chain" should be added as an index term?
Added, good idea.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2019-03-24 11:19:52 | Re: BUG #15708: RLS 'using' running as wrong user when called from a view |
| Previous Message | David Rowley | 2019-03-24 10:54:53 | Assert failure when validating foreign keys |