Re: Subtle bug in autoconf flex version test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Subtle bug in autoconf flex version test
Date: 2016-05-02 13:38:53
Message-ID: 11334.1462196333@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> The PGAC_PATH_FLEX version test in config/programs.m4 tests the major and minor
> versions with = rather than == which unless Im missing something is performing
> assignment rather than testing equality?

Huh. That's been broken since forever ... thanks for noticing!

> The attached diff makes the test
> trigger the expected warning on major/minor version on my OS X box (awk version
> 20070501).

Hm, is that a popular flex version? I wonder whether we will get
complaints if we start warning about it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-05-02 13:41:12 Re: Timeline following for logical slots
Previous Message Robert Haas 2016-05-02 13:33:36 Re: Detrimental performance impact of ringbuffers on performance