Re: BUG #7590: Data corruption using pg_dump only with -Z parameter

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Craig Ringer <ringerc(at)ringerc(dot)id(dot)au>
Cc: hrtlik(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #7590: Data corruption using pg_dump only with -Z parameter
Date: 2012-10-13 13:13:50
Message-ID: 11325.1350134030@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Craig Ringer <ringerc(at)ringerc(dot)id(dot)au> writes:
> On 10/10/2012 02:38 AM, Tom Lane wrote:
>> On Windows, that doesn't seem terribly surprising: Windows will probably
>> do newline munging on the process's stdout, which will corrupt
>> compressed data since it's not plain text.

> pg_dump might want to refuse to write to stdout when in a non-plain-text
> mode on Windows if that's the case.

Actually, a look at the pg_dump code says that it does

setmode(fileno(stdout), O_BINARY);

so either my diagnosis is wrong or there's some reason why that setting
didn't take.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jan Vodička 2012-10-13 13:28:08 Re: BUG #7590: Data corruption using pg_dump only with -Z parameter
Previous Message Jan Vodička 2012-10-13 12:14:37 Re: BUG #7590: Data corruption using pg_dump only with -Z parameter