Re: stderr & win32 admin check

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: stderr & win32 admin check
Date: 2004-06-14 21:07:46
Message-ID: 11321.1087247266@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> * Created function write_stderr(const char *fmt, ...), used before elog
> can be used. This function will write to stderr on unix and on win32
> fconsole. It will write to the eventlog on win32 when running as a
> service.
> * Changed all (most? I think I got all) fprintf(stderr,...) to use this
> function instead. That way, we gain the ability to put all the other
> preivously-stderr-messages to the eventlog as well.

I'm not sure this is a good idea. The remaining uses of stderr were
that way for a reason, not because someone had forgot to change them
into elog calls. It would be a lot less invasive to just move the
privilege check as you originally intended.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2004-06-14 21:14:26 Re: stderr & win32 admin check
Previous Message Magnus Hagander 2004-06-14 20:49:23 stderr & win32 admin check