Re: A note about debugging TAP failures

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: A note about debugging TAP failures
Date: 2017-04-25 15:00:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 24 Apr 2017, at 17:19, Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com> wrote:
> On 24 April 2017 at 20:01, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> I’m np Perl expert though so there might be better/cleaner ways to achieve
>> this, in testing it seems to work though. rmtree() is supported at least since
>> Perl 5.6 from what I can see.
> I'd rather just have the 'make' target nuke the relevant tmp_check dir
> before rerunning the tests. Right now it just deletes the logs.

Makes sense, assuming a “clean slate” to run on seems a reasonable assumption
for the test and it makes for simpler code in PostgresNode. Updated the patch
which now have static datadir names; retains on PG_TESTS_NOCLEAN or any kind of
test failure; and allows for cleaning datadirs without having to use make clean
(seems the wrong size hammer for that nail).

cheers ./daniel

Attachment Content-Type Size
tap_retaindir_v4.patch application/octet-stream 7.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2017-04-25 15:01:57 Re: PG 10 release notes
Previous Message Robert Haas 2017-04-25 15:00:16 Re: an outdated comment for hash_seq_init.