Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding

shihao zhong <zhong950419(at)gmail(dot)com> writes:
> Looks like we agree on the three-way rule, with the API Tom suggested.
> v3 attached, done the way Tom suggested.

It's late here, so these comments may be off-base, but:

* It occurred to me that we could avoid all the gettext_noop()
decorations by adding addQueryComment to GETTEXT_TRIGGERS.
This is a little bit magic perhaps, but we use that approach with
most functions that take a potentially-translated string.

* On Windows, this version of addQueryComment() performs a
gettext() lookup and then unconditionally discards the result.
Elsewhere it only conditionally discards the result, but neither
thing seems great. Should we invert the logic to avoid a useless
gettext lookup?

* Do we actually need to test for OUTPUT_CHARSET, given that
this code doesn't execute on Windows? My Linux man page for
gettext does not indicate that it responds to OUTPUT_CHARSET,
so I'm wondering if that is a Windows-only thing.

regards, tom lane