Re: PG10 pgindent run

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG10 pgindent run
Date: 2017-05-14 22:38:52
Message-ID: 1128.1494801532@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-05-14 17:22:16 -0400, Stephen Frost wrote:
>> Releasing alpha/beta is not the same as branching, which I didn't expect
>> us to do for a while yet..

> Well, tagging then. Imo it still should be done before we tag
> beta1/alpha1.

Too late, IMO. Yeah, I'd have preferred to pgindent before beta1 too,
just in case pgindent breaks something ... but it's been a long time
since that happened, so realistically, not having done it yet is not
going to meaningfully degrade the relevance of beta testing.

At this point, for Bruce to do it before the wrap, he'd pretty much
have to do it tonight, which we already agreed among the release team
is not enough notice.

Also, I liked the approach Robert took last year where he did a dry
run and then manually fixed places that he saw would get messed up
by pgindent. That's a lot more pleasant than undoing such damage
afterwards. I don't know if Robert plans to do that this year, but if
not, I'm planning to get to it tomorrow or Tuesday. I can't do it
right now because I'm still on higher-priority tasks.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-05-14 22:41:14 Re: Hash Functions
Previous Message Tom Lane 2017-05-14 22:30:51 Re: Hash Functions