Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Dave Rolsky <autarch(at)urth(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist
Date: 2013-02-16 16:35:01
Message-ID: 11257.1361032501@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Fri, Feb 15, 2013 at 04:06:12PM -0600, Dave Rolsky wrote:
>> Fair enough. It should probably an option to add "if exists", at
>> least. I can't imagine I'm the only using this tool to ship database
>> updates around to different machines, some of which may not have new
>> tables. I'd really like to be able to know when the restore fails
>> versus when it succeeds but is noisy.

> All I can say is I don't remember anyone asking for this in the past.

I think it has come up before. I wouldn't object to a pg_dump option to
add IF EXISTS to all the drop commands (though changing the default
behavior would be more controversial). Don't intend to spend my own
time on it though ...

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Pavel Stehule 2013-02-16 17:47:31 Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist
Previous Message John R Pierce 2013-02-16 00:48:17 Re: BUG #7884: pg_upgradecluster is terribly slow

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-02-16 16:42:31 [RFC] indirect toast tuple support
Previous Message Tomas Vondra 2013-02-16 15:41:56 Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system