Re: remove pg_restrict workaround

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: remove pg_restrict workaround
Date: 2025-10-15 13:58:33
Message-ID: 1125196.1760536713@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> When in C11 mode, MSVC supports the standard "restrict" keyword, so we
> don't need the workaround with using "pg_restrict" instead anymore.
> (Just for clarification, restrict is a C99 feature, but MSVC only
> accepts it properly in C11 mode.) So I'm proposing to remove that
> workaround here, so that code can use the standard restrict keyword
> without having to worry about the alternative spelling.

Won't this break extensions that are using pg_restrict? Sure, they
could update their code, but then maybe it wouldn't work anymore
against previous branches. Seems like it'd be better to leave
pg_restrict in place (for awhile anyway) but always #define it
as "restrict". I don't mind ceasing to use it within our own tree
though.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin K Biju 2025-10-15 14:00:39 Re: Replace O_EXCL with O_TRUNC for creation of state.tmp in SaveSlotToPath
Previous Message Uilian Ries 2025-10-15 13:37:13 Feature Request: Build only backend libraries with Meson