Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB barriers

From: Greg Burd <greg(at)burd(dot)me>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dave Cramer <davecramer(at)gmail(dot)com>
Subject: Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB barriers
Date: 2025-11-20 22:08:33
Message-ID: 111DDB2C-4A13-48B8-A0B2-615184497324@greg.burd.me
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Nov 20 2025, at 5:00 pm, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:

> On 20.11.25 21:45, Greg Burd wrote:
>> Dave and I have been working together to get ARM64 with MSVC functional.
>> The attached patches accomplish that. Dave is the author of the first
>> which addresses some build issues and fixes the spin_delay() semantics,
>> I did the second which fixes some atomics in this combination.
>

Hi Peter,

Thanks for taking a second to review.

> > - zlib_t = dependency('zlib', required: zlibopt)
> > + zlib_t = dependency('zlib', method : 'pkg-config', required: zlibopt)
>
> This appears to be a change unrelated to your patch description.

Hmmm, these are changes that Dave added to get things to compile. They
worked for me but I'll review them again in the morning and update the description.

> Also, the second patch contains a number of random whitespace changes.
> It would be good to clean that up so the patch is easier to analyze.

Certainly, apologies. I'll clean that up first thing in the morning.

-greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-11-20 22:08:37 Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
Previous Message Peter Eisentraut 2025-11-20 22:00:13 Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB barriers