| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VS 2015 support in src/tools/msvc |
| Date: | 2016-03-08 16:17:24 |
| Message-ID: | 11199.1457453844@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 03/08/2016 10:43 AM, Tom Lane wrote:
>> However, there definitely *is* a hard requirement on perl for Windows
>> builds, even from tarballs, and I thought this patch was only about
>> the Windows build?
> Michael's patch proposes to replace the use of sed to generate probes.h
> with the perl equivalent everywhere. That has the advantage that we keep
> to one script to generate probes.h, but it does impose a perl dependency.
Meh.
> We could get around that by shipping probes.h in tarballs, which seems
> like a perfectly reasonable thing to do.
Well, it'd be messier than you think, because you could not just ship
a dummy probes.h, or make would think it was up to date and not replace
it even in a dtrace-using build. You'd have to ship it as something
like "probes.dummy.h" and cp it into place at build time.
On the whole, I'd rather that this patch left the non-Windows side alone.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2016-03-08 16:20:29 | Re: [HACKERS] How can we expand PostgreSQL ecosystem? |
| Previous Message | Amit Langote | 2016-03-08 16:16:26 | Re: [PROPOSAL] VACUUM Progress Checker. |