From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Jaime Casanova <systemguards(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: rewriter in updateable views |
Date: | 2005-03-28 08:51:52 |
Message-ID: | 1111999912.11750.881.camel@localhost.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, 2005-03-27 at 23:12 -0500, Jaime Casanova wrote:
> On Sat, 19 Mar 2005 11:42:18 +0000, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > I can see that I might want the view to have a different default value
> > from that of the underlying table. I can see a reason to have multiple
> > updateable views on the same table, all with different columns, column
> > defaults and row selection clauses. (Multiple classes all held within
> > the same physical table, for example).
> >
> > I'd suggest - if the default value for a column on a view IS NOT set,
> > then use the default value from the underlying table. If it IS set, then
> > it should stay set, even if the underlying table changes. That might
> > need some dependency logic in there...
> >
> I think i can do this within rewriterHandle.c:build_column_default
> immediatly after the first try i can ask if expr == NULL and if is it
> a view if so my code start looking for defaults on base tables maybe
> using something like the parse_relation.c:colNameToVar function to
> identify the column. there is a better way to do it? also the
> ParseState parameter is extensively used in the colNameToVar function
> but i can't find what is it.
ParseState is defined in src/include/parser/parse_node.h
I'm not sure I can comment further.
If you have everything else working, it might be worth submitting a
patch for review? There may be other things required also.
Best Regards, Simon Riggs
From | Date | Subject | |
---|---|---|---|
Next Message | Tsirkin Evgeny | 2005-03-28 09:52:34 | is postgresql 8 is realy mature |
Previous Message | Alexey Slynko | 2005-03-28 08:16:42 | Patch for database locale settings |