Re: WIP: pl/pgsql cleanup

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: WIP: pl/pgsql cleanup
Date: 2005-01-21 01:09:41
Message-ID: 1106269781.22946.260.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

On Thu, 2005-01-20 at 15:48 +1100, Neil Conway wrote:
> Attached is a revised patch (no major changes, just grammar cleanup).
> While rewriting some cruft in PL/PgSQL's gram.y, I noticed that we will
> overflow a heap-allocated array if the user specifies more than 1024
> parameters to a refcursor (a demonstration .sql file is also attached).
> I think this is probably worth backpatching to 8.0 (and earlier?) --
> I've attached a quick hack of a patch that fixes the issue, although of
> course the fix for 8.1 is nicer.

I've applied the minimal fix for the buffer overrun to REL7_4_STABLE and
REL8_0_STABLE (let me know if you think it's worth backpatching

I'll post a revised patch for HEAD that does the falloc() stuff soon.


In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Euler Taveira de Oliveira 2005-01-21 03:54:17 Re: uptime function to postmaster
Previous Message Neil Conway 2005-01-21 01:09:20 regression: pass with no default WITH OIDS