Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Raphael Hertzog <hertzog(at)debian(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Date: 2017-11-07 14:58:41
Message-ID: 11052.1510066721@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Raphael Hertzog (hertzog(at)debian(dot)org) wrote:
>> Still I believe that this issue should be fixed in both sides. It's not
>> smart from PostgreSQL to call fsync() when it has not made any change.

> Why?

My thought about this is just to ignore EINVAL when fsync'ing a directory,
as we already do with EBADF.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Stephen Frost 2017-11-07 15:00:03 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Previous Message Raphael Hertzog 2017-11-07 14:57:03 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there