Re: Implementing RESET CONNECTION ...

From: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Oliver Jowett <oliver(at)opencloud(dot)com>, Kris Jurka <books(at)ejurka(dot)com>, Hans-Jürgen Schönig <postgres(at)cybertec(dot)at>, eg(at)cybertec(dot)at, List pgsql-patches <pgsql-patches(at)postgreSQL(dot)org>
Subject: Re: Implementing RESET CONNECTION ...
Date: 2005-01-04 08:08:40
Message-ID: 1104826120.3597.24.camel@petra
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, 2005-01-03 at 20:27 -0500, Tom Lane wrote:

> I'm inclined to think that we'd have to add a protocol message that
> reports RESET CONNECTION to really answer objections of this type.
> That seems to bring the thing into the category of "stuff that forces
> a protocol version bump" :-(
>
> Perhaps RESET CONNECTION should be a protocol-level operation instead
> of a SQL command? That would prevent user-level code from causing it
> without the driver knowing.

I still don't see a big difference between DEALLOCATE and RESET -- both
can break the JDBC driver. I'm not sure if we need prevent bad usage of
PG tools (JDBC in this case). The DEALLOCATE/RESET usage is under user's
full control and everything can be described in docs.

I think each PG command returns some status. For example in libpq it's
possible check by PQcmdStatus(). I think JDBC can checks this status (by
own PQcmdStatus() implementation) and if PG returns string "CONNECTION-
RESETED" it can deallocate internal stuff. This solution doesn't require
touch the protocol.

Karel

--
Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2005-01-04 08:36:20 Re: [HACKERS] Bgwriter behavior
Previous Message Greg Stark 2005-01-04 06:46:53 Re: uptime() for postmaster

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2005-01-04 08:34:32 Re: Another Plpgsql trigger example - summary table
Previous Message Bruce Momjian 2005-01-04 05:13:52 Re: [HACKERS] Bgwriter behavior