Re: partitioned tables and contrib/sepgsql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Mike Palmiotto <mike(dot)palmiotto(at)crunchydata(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: partitioned tables and contrib/sepgsql
Date: 2017-04-06 15:29:58
Message-ID: 11037.1491492598@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joe Conway <mail(at)joeconway(dot)com> writes:
> I'm going to push the attached in a few hours unless there is any
> additional discussion. As stated above we'll do the regression changes
> in a separate patch once that is sorted. I used Tom's approach and
> comment wording for 0001a.

Looks generally sane, but I noticed a grammatical nitpick:

- * Only attributes within regular relation or partition relations have
+ * Only attributes within regular relations or partition relations have

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-04-06 15:33:16 Re: Uninitialized variable introduced in 3217327053638085d24dd4d276e7c1f7ac2c4c6b
Previous Message Tom Lane 2017-04-06 15:21:52 Re: No-op case in ExecEvalConvertRowtype