| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |
| Date: | 2017-05-09 14:29:16 |
| Message-ID: | 10f4e61d-f277-fafd-a87e-8c63e6cba0b2@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/9/17 03:27, Masahiko Sawada wrote:
> I think we should change tab-completion support for that as well.
>
> diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
> index 183fc37..046fdd5 100644
> --- a/src/bin/psql/tab-complete.c
> +++ b/src/bin/psql/tab-complete.c
> @@ -2684,7 +2684,7 @@ psql_completion(const char *text, int start, int end)
>
> /* DROP SUBSCRIPTION */
> else if (Matches3("DROP", "SUBSCRIPTION", MatchAny))
> - COMPLETE_WITH_LIST2("DROP SLOT", "NODROP SLOT");
> + COMPLETE_WITH_LIST2("CASCADE", "RESTRICT");
>
> /* EXECUTE */
> else if (Matches1("EXECUTE"))
Thanks for pointing that out. I just moved it under the generic DROP
support section.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2017-05-09 14:47:40 | Re: idea: custom log_line_prefix components besides application_name |
| Previous Message | Peter Eisentraut | 2017-05-09 14:28:02 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |