| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Steven Niu <niushiji(at)gmail(dot)com> |
| Cc: | Pierre <pierre(dot)forstmann(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] check kernel version for io_method |
| Date: | 2026-01-14 17:26:27 |
| Message-ID: | 10a90d37-3471-4ea4-a492-117c7997d4ed@proxel.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/14/26 12:14 PM, Jakub Wartak wrote:
> I haven't looked at this patch, however the above statement is not
> completely true. There is a parallel problem [1] related to kernel
> version, where if you do not run proper kernel version (>= 6.5) or
> proper liburing version, then fork() (-> all connections established)
> are going to be slow slugging under more than basic load due to lack
> of "combined memory mapping creation" (so technically speaking
> recommending someone to go to 5.6.x but < 6.5 IMHO is also not good
> advice). See first message in that [1] for a performance report about
> this. IMHVO if we are checking for kernel versions we could also warn
> about performance regression (something like merge those two patches
> if one wants to have a good io_uring experience).
We can probe for that too, which we already do. If you call
pgaio_uring_ring_shmem_size() it will return 0 on Linux <6.5. Which I
think eve further supports probing for the features we need rather than
looking at the kernel version.
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-01-14 17:54:01 | Re: pg_upgrade: optimize replication slot caught-up check |
| Previous Message | Japin Li | 2026-01-14 16:52:35 | Re: GIN pageinspect support for entry tree and posting tree |