Re: contrib/xml2: add function xml_encode_special_chars

On Sun, 2004-11-07 at 12:56, Markus Bertheau wrote:
> В Вск, 07.11.2004, в 09:33, Simon Riggs пишет:
> > On Sat, 2004-11-06 at 23:42, Markus Bertheau wrote:
> > > В Сбт, 06.11.2004, в 23:13, Simon Riggs пишет:
> > > > On Sat, 2004-11-06 at 00:36, Markus Bertheau wrote:
> > > > > В Сбт, 06.11.2004, в 01:24, Peter Eisentraut пишет:
> > > > > > Markus Bertheau wrote:
> > > > > > > attached is a patch that adds the function xml_encode_special_chars
> > > > > > > to the xml2 contrib module. It's against 8.0beta4. It's intended for
> > > > > > > commit.
> > > > > >
> > > > > > Would you also tell us what this function does?
> > > > >
> > > > > It calls the similarly named function from libxml2. It replaces
> > > > > characters that carry a special meaning in XML (<, >, &, " and \r) with
> > > > > their respective XML entities.
> > > >
> > > > Wow! Hadn't noticed xml2 didn't do that. Thats pretty important...
> > >
> > > What do you mean, it didn't do that? Where had you expected it to do
> > > that?
> >
> > eh? I'm agreeing that your patch is important...
>
> I didn't question that :) I just don't understand what you mean with
> "xml2 doesn't do that" - do you mean that you thought that that function
> was already there? Or that special character encoding already takes
> place somewhere else in xml2? I can't imagine where that would be, so I
> asked :)

I mistakenly assumed that the special character encoding took place
automatically, without calling a specific function.

It's pretty fragile without that, but you could go a long way before the
lack of it hit you in the face, then no further.

--
Best Regards, Simon Riggs