Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Centralize definition of integer limits.
Date: 2015-03-30 19:38:16
Message-ID: 10996.1427744296@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Mon, Mar 30, 2015 at 7:48 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> On 2015-03-30 14:01:25 +0900, Michael Paquier wrote:
>>> My OSX dev box is generating a couple of warnings since this commit:
>>> pg_dump.c:14548:45: warning: format specifies type 'long' but the
>>> argument has type 'long long' [-Wformat]

FWIW, I'm seeing the same thing on my OSX laptop. I think the explanation
is simple: both "long" and "long long" are 64 bits on this machine.
Our configure chooses the former to be "int64", but stdint.h is using
the latter. I'm not sure there's any good way to know what stdint.h
thinks is int64, but we can't do a half-baked integration job like this.
Either we revert 83ff1618b altogether, or we make int64/uint64 depend
on definitions from stdint.h rather than being chosen independently by
configure.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-03-30 19:50:09 Re: [COMMITTERS] pgsql: Centralize definition of integer limits.
Previous Message Alvaro Herrera 2015-03-30 19:29:14 pgsql: Change array_offset to return subscripts, not offsets

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-03-30 19:50:09 Re: [COMMITTERS] pgsql: Centralize definition of integer limits.
Previous Message Alvaro Herrera 2015-03-30 19:30:17 Re: proposal: searching in array function - array_position