Re: autovacuum and TOAST tables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: autovacuum and TOAST tables
Date: 2008-08-11 23:06:41
Message-ID: 10988.1218496001@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Hmm, we could probably fix that if we made the cluster operation swap
> the physical storage of the two toast tables, rather than swapping the
> tables altogether. I agree it's not critical but it could be confusing.

On second thought, I think it *could* lead to a visible failure.
Suppose the OID counter wraps around and the OID that had been used for
the temporary CLUSTER table gets assigned to a new table. If that table
needs a toast table, it'll try to create one using the name that is
already in use. We have defenses against picking an OID that's in use,
but none for toast table names. So I think it's indeed worth fixing.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Casey Duncan 2008-08-12 00:43:55 Re: Mini improvement: statement_cost_limit
Previous Message Tom Lane 2008-08-11 22:58:37 Re: autovacuum and TOAST tables