Re: [psql] Setting the PROMPT on command line

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ingo van Lil <inguin(at)gmx(dot)de>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [psql] Setting the PROMPT on command line
Date: 2004-10-07 03:41:14
Message-ID: 1097120473.13817.6.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Thu, 2004-10-07 at 13:05, Tom Lane wrote:
> I'm just wondering if the fix is in the right place. Doesn't the same
> issue arise for other variables?

Well, we don't manually set other variables in psql itself, with the
exception of defining some default values before we process command-line
args or psqlrc (see startup.c circa line 141) -- so in that case
allowing the value to be overriden is fine.

On looking at the code closer though, I do see one related problem: we
process command-line args before we read psqlrc, so psqlrc settings can
override what was specified on the command-line. Shouldn't this happen
in reverse?

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Reini Urban 2004-10-07 03:46:32 pg_ctl: WIN32 for CYGWIN also (services)
Previous Message Tom Lane 2004-10-07 03:05:13 Re: [psql] Setting the PROMPT on command line