Sami Imseih <samimseih(at)gmail(dot)com> writes:
> e3a87b499 states "There's no intention to make wholesale
> changes of existing ereport calls ..."
> Why do it for pg_stat_statements only when there are a bunch
> of other places?
I think we should flat out reject this patch. It makes no functional
improvement while creating a merge hazard for future back-patches.
That hazard might not be very large for just changing these few
spots, but any more-aggressive attempt at changing existing ereports'
style will certainly result in pain.
As e3a87b499 said, there was no plan to change existing code and
I think that decision should still stand.
regards, tom lane